Rework CI Docker to use UV and fix ResNet18 test #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viv-eth
requested changes
Jan 21, 2026
viv-eth
left a comment
viv-eth
left a comment
There was a problem hiding this comment.
LGTM and the tests are passing. I only had a minor nitpick and once this is resolved, we can land this PR.
There was a problem hiding this comment.
Minor question; do we really want the -s flag in the ModelTests run? It is useful for debugging, but in the CI it would just create huge logs.. Unless there is a good reason to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed
uvto prepare the dependencies in the uv cache.